Move all BaseHook usages to version_compat in openai#52819
Merged
amoghrajesh merged 9 commits intoapache:mainfrom Jul 6, 2025
Merged
Move all BaseHook usages to version_compat in openai#52819amoghrajesh merged 9 commits intoapache:mainfrom
amoghrajesh merged 9 commits intoapache:mainfrom
Conversation
dominikhei
reviewed
Jul 4, 2025
Contributor
dominikhei
left a comment
dominikhei
left a comment
There was a problem hiding this comment.
Why are you importing the BaseHook from facebook.version_compat and not from openai?
mingdaoy
commented
Jul 4, 2025
Contributor
|
@mingdaoy there is a static check failure: The best way to ensure this doesn't happen is to have precommit set up locally: https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#pre-commit-hooks It will run all these checks for you and save a lot of time! |
amoghrajesh
approved these changes
Jul 5, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
This one should get through now, thanks!
Contributor
|
Ah, the redis tests are unrelated and are tracked here: #52906 |
Contributor
|
Right, we are green now! |
HsiuChuanHsu
pushed a commit
to HsiuChuanHsu/airflow
that referenced
this pull request
Jul 10, 2025
Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
stephen-bracken
pushed a commit
to stephen-bracken/airflow
that referenced
this pull request
Jul 15, 2025
Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #52676
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.